Add example programs using condition variables from pldi23#10
Open
andrew-chang-dewitt wants to merge 15 commits intosmuller:condvarfrom
Open
Add example programs using condition variables from pldi23#10andrew-chang-dewitt wants to merge 15 commits intosmuller:condvarfrom
andrew-chang-dewitt wants to merge 15 commits intosmuller:condvarfrom
Conversation
andrew-chang-dewitt
force-pushed
the
condvar/examples
branch
from
1c275f5 to
0157866
Compare
andrew-chang-dewitt
force-pushed
the
condvar/examples
branch
from
32a936f to
6f7c604
Compare
priml-examples/cv-inversion-err.prm
Outdated
Comment on lines
35
to
39
| (* FIXME: or should we add inline types to fn signature? *) | ||
| (* FIXME: how to specify arg type as a condition variable? *) | ||
| (* FIXME: is `int ref` the correct way to specify res is a refererence? *) | ||
| (* | ||
| fun[low] foo (cv: cv[high]) (res: int ref) = |
Collaborator
Author
There was a problem hiding this comment.
Is using inline types in the function signature the correct way to specify the priority of a condition variable argument to a function (e.g. (cv: cv[high]) as seen in line 39)?
Owner
There was a problem hiding this comment.
You'd need to add syntax for the CV type to the parser, so the syntax is up to you. cv[] seems like good syntax to me. I never got around to this for mutexes. Type annotations are generally unnecessary in ML (other than as documentation), so it's possible to get by without it.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Code to parse all examples correctly now has been pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds examples, translated to PriML, from "Responsive Parallelism with Synchronization" paper.
TODO:
cv[priority]type to parsingfun[priority]syntax