Potential fix for shields and spears

[tangoethan]

Changes the getMaxUseTime Item Mixin to exclude shields and spears.
This should fix the occasional damage applying through shields and spears acting weird.
Most of my testing was on 1.21.9-1.21.11, but this change should work on older versions that have the shield bug, and not affect those that don't (I did a quick code check for 1.19.2+).

Alternatively, I believe adding || original == 72000 to the if statement would also work.

Resolves #62 and resolves #42

[Lemonnik6484]

Thank you for this fix, I'll test it later today and leave my review

[JXSnack]

This is awesome! How did you come to this solution? Nevermind, I'm blind

[JXSnack]

LGTM
Tested in multiplayer 1.21.11 - works as intended without any visible side effects

[Lemonnik6484]

Looks good

[ench233]

good waht???

and in mixin L1:
if (!TT20.config.enabled() || !TT20.config.eatingAcceleration() || original == 0) return original;

so this pr fixed air lol..how did you passed test?

[ench233]

add check of original == 72000 can solve shield issue, but im not sure if it affects on spear

[JXSnack]

I have no idea what you're talking about. Maybe give some additional context to what you mean instead of giving destructive feedback?

Please state:

• the Minecraft version
• your concern
• explanation on why this doesn't work

This PR fixes both the shield and spear issue. I've tested it and I can show you the individual pieces of code that do this.

[Lemonnik6484]

I believe that || original == 0 was supposed to prevent second return from being recalculated. As we saw it did not work like that, so now we have ordinal = 0 which forces only first return to be edited. In fact the solution is still the same, but uses a different approach that obviously works now. So we can probably remove that || original == 0.

Anyways, be polite next time and explain what you mean