Add support for perturbation magnitude/direction#17
Open
giladmishne wants to merge 1 commit intosnap-stanford:masterfrom
Open
Add support for perturbation magnitude/direction#17giladmishne wants to merge 1 commit intosnap-stanford:masterfrom
giladmishne wants to merge 1 commit intosnap-stanford:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies perturbation names to include an optional magnitude, separated from the gene name by
*, i.e.p53*200,brca2*0. The magnitude is an integer, interpreted as a percentage change from base (i.e. 0 is a knockout), and is used to multiply the perturbation embedding. If no magnitude is provided, a default one of 100% is used (to be backward-compatible with the current implementation).Many of the changes are trailing-whitespace removals from an auto-formatter; the only real modifications are parsing and storing an additional
pert_magnitudearray with the rest of the data and using it to modify the embedding.