Address a potential problem while creating a training dataset with dense array inputs#78
Open
HelloWorldLTY wants to merge 2 commits intosnap-stanford:masterfrom
Open
Address a potential problem while creating a training dataset with dense array inputs#78HelloWorldLTY wants to merge 2 commits intosnap-stanford:masterfrom
HelloWorldLTY wants to merge 2 commits intosnap-stanford:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I notice that the current pre-processing step for creating the dataset assumes input data are formed as sparse data (adata.X is sparse matrix), so if the input data form as dense matrix, there will be an error:
Therefore, I modify the current codes which will be suitable for either sparse matrix or dense matrix as inputs.
Moreover, I also notice that gears will compute DEGs for the further work related to metrics, but if there is only one cell under such perturbation, an error will be thrown:
Therefore, I also recommend modifying the tutorial to warn such condition. Thanks.