Skip to content
This repository was archived by the owner on Dec 8, 2025. It is now read-only.

Conversation

@Frank-Geisler
Copy link

Hi!

There were some minor issues in New-SnipeitUser that I fixed:

  • Some Typos in the description
  • added password to be mandatory
  • added a test that if the password is less than 8 characters we will have an exception because the WebAPI does not like passwords with less than 8 characters. Test now is through ValidateScript

Have a good one

Frank

erikjunker and others added 10 commits October 6, 2022 19:03
Rebased Fix/jorips1 orginal PR

New/Set licenses
Removed Validate Length from New-SnipeitLicense -license_email, bringing it in line with Set. This was causing the parameter to fail as it cannot validate the mailaddress object.
Added code to convert -license_email to string, as required by the SnipeitAPI.
Added -purchase_order functionality.

New Supplier
Fixed typo in API which was causing the command to fail.
@PetriAsi
Copy link
Contributor

Hi, thanks for fixes. I'm happy to merge this. Could you please change to little things. rebase you changes agains current delvelop branch and change this PR to reference develop instead master. Rebasing will keep changelog tidy by removind all unneeded commits from PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants