Fix/mz dataremoval #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warning in loadRmbSettings('mysettings.ini') in issue #257
Updating to latest version of MassBank/RMassBank dev
…nce again to avoid a duplicate. (This was added to "Suggests" in the updated and merged version as well)
Introduced new slots `AC$MASS_SPECTROMETRY$MS_SCAN_LOWER_LIMIT` and `AC$MASS_SPECTROMETRY$MS_SCAN_UPPER_LIMIT`.
Scan range is now stored as a string in the subtag `SCAN_RANGE_M/Z` of `AC$MASS_SPECTROMETRY`. Example: `AC$MASS_SPECTROMETRY: SCAN_RANGE_M/Z "50-210"`
…emanded by the specification
…he entry prefix is not 2. This would lead to the length of the accession number being different from 8 which makes it unusable for the databse. Hence, the user is informed via the warning that the so-constructed accession numbers should be used for internal purposes only.
Arbitrary number of letters in accession number prefix
Inclusion of scan range in record format
Fix Travis error caused by R version
…MassBank.Rmd` This addresses #194
Project tag inclusion
… to address #175 TODO: address warnings caused by nested list
Note: The unlist function behaves very unexpectedly. See the comment in buildRecord.R, line 165ff for details Typo correction: This branch actually addresses #176
@sneumann See new function `.addGenericInfo`
Creating more flexible structure in AC$CHROMATOGRAPHY to allow for third SOLVENT
Fix an issue if no electronic noise was specified in settings.ini, closes #239
…esent - Replaced 'cat' by 'warning' - Refrained from writing outliers to an extra csv-file
Added check whether peaks are in scan range
This addresses #289
Updated DESCRIPTION and NAMESPACE to include the logger package
- no internal variable in the RMassBank environment is used anymore - instead, an RMassBank logging namespace is created immediately in `settings_example.R`, if a logging file was given - Removed update_appender method (not necessary anymore) Renamed log_xxx functions to rmb_log_xxx
Implemented log-wrapper
Mass range as integers
Update email of Erik and addition of Paul as an author
Adjusted rounding of mass range
# Conflicts: # DESCRIPTION
…d so Windows builds are single arch only (i.e. 64-bit only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.