Feature: Solana cbor and compact-u16 decoding#7
Merged
Conversation
This branch introduces components required for connecting Solana wallets through Keystone, signing Solana transactions as well as decoding variable-length integers in Solana. List of changes: - updated a_cbor_tagged_object.dart and cbor_special_tag.dart to include new Solana elements - created cbor_crypto_multi_accounts.dart, used to connect Solana wallets - created cbor_sol_sign_request.dart and cbor_sol_signature.dart, used to request and return Solana signature - created compact_u16_decoder.dart, used for decoding variable-length integers in Solana - created byte_reader.dart, a helper used for sequential reading of binary data - unrelated with domain: updated base58_codec.dart to fix an issue where the decode() method applied zero-byte padding on top of the already decoded value when the input consisted entirely of '1' Base58 characters. For example, decoding 32 zeros returned the decoded value of 0 and padding added 32 zeros on top of it, returning 33 zeros in total, instead of 32. It caused the Solana System Program address to be decoded incorrectly. Solana System Program is the most important program of all, responsible for: new account creation, space allocation, assigning program ownership and transferring SOL.
kronikarz
approved these changes
Dec 12, 2025
balladyna
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch introduces components required for connecting Solana wallets through Keystone, signing Solana transactions as well as decoding variable-length integers in Solana.
List of changes: