Skip to content

[CLIENT] [ACCESSIBLE-COMPONENT] Button Component - Link#66

Merged
Hemangshu-Dey merged 3 commits intomainfrom
page/accessible-component-Link-button
Nov 27, 2025
Merged

[CLIENT] [ACCESSIBLE-COMPONENT] Button Component - Link#66
Hemangshu-Dey merged 3 commits intomainfrom
page/accessible-component-Link-button

Conversation

@codeSubhajit0
Copy link
Copy Markdown
Contributor

@codeSubhajit0 codeSubhajit0 commented Oct 25, 2025

COMPONENTLAB : PULL-REQUEST

Description

  • Added accessible link button .

Issue worked on

Issue link #49

Changes Made

  • Feature added
  • Bug fixed
  • Test coverage
  • Code refactoring
  • Code optimization
  • Documentation updated

Test Checklist

  • Tests have been added/updated if needed
  • Test coverage is >80%

General Checklist

  • Code follows the project’s style guidelines
  • Documentation has been updated if necessary
  • Done local formatting of the code written
  • Branch is updated with base branch

@SUVAJIT-KARMAKAR SUVAJIT-KARMAKAR changed the title page(accessible-component-Link-button): Added link button and fixed s… [CLIENT] [ACCESSIBLE-COMPONENT] Button Component - [Link] Oct 27, 2025
Copy link
Copy Markdown
Contributor

@SUVAJIT-KARMAKAR SUVAJIT-KARMAKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly address the changes and update the code-base ! Overall great job man 😁

Comment thread src/app/buttons/link/page.tsx Outdated
Comment thread src/lab/AccessibleButtons/Link/LinkButtonVariant.code.ts Outdated
Comment thread src/lab/AccessibleButtons/Link/LinkButtonVariant.tsx
Comment thread src/lab/AccessibleButtons/Link/LinkButtonVariant.tsx Outdated
@SUVAJIT-KARMAKAR
Copy link
Copy Markdown
Contributor

SUVAJIT-KARMAKAR commented Oct 27, 2025

@codeSubhajit0 , Kinly format the code-base before committing the latest changes !

bun run format

@SUVAJIT-KARMAKAR SUVAJIT-KARMAKAR changed the title [CLIENT] [ACCESSIBLE-COMPONENT] Button Component - [Link] [CLIENT] [ACCESSIBLE-COMPONENT] Button Component - Link Nov 27, 2025
Copy link
Copy Markdown
Contributor

@SUVAJIT-KARMAKAR SUVAJIT-KARMAKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let @Hemangshu-Dey approve these changes ! Good work man 😁

Comment thread src/lab/AccessibleButtons/Link/LinkButtonVariant.tsx
Copy link
Copy Markdown
Contributor

@Hemangshu-Dey Hemangshu-Dey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hemangshu-Dey Hemangshu-Dey merged commit ea8a6e6 into main Nov 27, 2025
6 checks passed
@Hemangshu-Dey Hemangshu-Dey deleted the page/accessible-component-Link-button branch November 27, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants