[async] test fixes

Author: sfc-gh-fpawlowski

src/snowflake/connector/aio/_session_manager.py

@@ -585,17 +585,24 @@ def make_session(self, *, url: str | None = None) -> aiohttp.ClientSession:
             session_manager=self.clone(),
             snowflake_ocsp_mode=self._cfg.snowflake_ocsp_mode,
         )
-        # We use requests.utils here (in asynch code) to keep the behaviour uniform for synch and asynch code. If we wanted each version to depict its http library's behaviour, we could use here: aiohttp.helpers.proxy_bypass(url, proxies={...}) here
-        proxy = (
-            None
-            if should_bypass_proxies(url, no_proxy=self.config.no_proxy)
-            else self.proxy_url
-        )
+
+        proxy_from_conn_params: str | None = None
+        if not aiohttp.helpers.proxies_from_env():
+            # TODO: This is only needed because we want to keep compatibility with the synch driver version.
+            #   Otherwise, we could remove that condition and always pass proxy from conn params to the Session constructor.
+            #   But in such case precedence will be reverted and it will overwrite the env vars settings.
+
+            # We use requests.utils here (in asynch code) to keep the behaviour uniform for synch and asynch code. If we wanted each version to depict its http library's behaviour, we could use here: aiohttp.helpers.proxy_bypass(url, proxies={...}) here
+            proxy_from_conn_params = (
+                None
+                if should_bypass_proxies(url, no_proxy=self.config.no_proxy)
+                else self.proxy_url
+            )
         # Construct session with base proxy set, request() may override per-URL when bypassing
         return self.SessionWithProxy(
             connector=connector,
             trust_env=self._cfg.trust_env,
-            proxy=proxy,
+            proxy=proxy_from_conn_params,
         )
 
 

test/unit/aio/test_proxies_async.py

@@ -679,10 +679,10 @@ async def test_proxy_env_vars_take_precedence_over_connection_params(
     flags = await _collect_proxy_precedence_flags(
         proxy_from_conn_params, proxy_from_env_vars, target_wm
     )
-    assert (
+    assert not (
         flags.proxy1_saw_request
     ), "proxy_from_conn_params (connection param proxy) should NOT have seen the query request"
-    assert not flags.proxy2_saw_request, (
+    assert flags.proxy2_saw_request, (
         "proxy_from_env_vars (env var proxy) should have seen the request "
         "since connection params take precedence"
     )