Async connect context manager support - approach 2 - aenter refactored into separate prepare method. #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Berkay Öztürk <info@berkayozturk.net> (cherry picked from commit 87c623e)
…er for async with SessionWithProxy
…ted method to prepare connection for entering its context.
Comment on lines
+169
to
+173
| def _prepare_aenter(self) -> None: | ||
| """ | ||
| All connection changes done before entering connection context have to be done here, as we expose the same api through snowflake.connector.aio.connect() and call this function there at __aenter__ as well. | ||
| """ | ||
| pass |
Contributor
Author
There was a problem hiding this comment.
That was the clue of this (second) approach - to prevent future differences between with SnowflakeConnection() vs with connect(). But I think I am more in favour of the first one so I am closing this today, unless any objections are there.
Comment on lines
+75
to
+82
| self.__wrapped__ = SnowflakeConnection.__init__ | ||
| self.__name__ = "connect" | ||
| self.__doc__ = SnowflakeConnection.__init__.__doc__ | ||
| self.__module__ = __name__ | ||
| self.__qualname__ = "connect" | ||
| self.__annotations__ = getattr( | ||
| SnowflakeConnection.__init__, "__annotations__", {} | ||
| ) |
Contributor
There was a problem hiding this comment.
All of those are by default reassigned when using @wraps (in update_wrapper)
Contributor
Author
There was a problem hiding this comment.
Correct - I leaned toward this first approach proposal so I have addressed it there - ptal
#2614
Base automatically changed from
cherrypicks-to-aio-connector-part23a
to
dev/aio-connector
October 29, 2025 11:48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach 2 - not idempotent aenter but separate prepare method.
Main benefit - not relying on conn.is_closed() in SnowflakeConnection.aenter (no unnecessary logic there).
Main drawback:
Analogous to: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1376-L1412