-
Notifications
You must be signed in to change notification settings - Fork 527
NO-SNOW: remove unused connection _connected flag #2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfc-gh-fpawlowski
wants to merge
26
commits into
dev/aio-connector
Choose a base branch
from
NO-SNOW-remove-unused-connection-connected-flag
base: dev/aio-connector
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NO-SNOW: remove unused connection _connected flag #2627
sfc-gh-fpawlowski
wants to merge
26
commits into
dev/aio-connector
from
NO-SNOW-remove-unused-connection-connected-flag
+335
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
489c367 to
35f2b09
Compare
sfc-gh-turbaszek
approved these changes
Nov 5, 2025
…changes to skip fialing tests so lets fix in next commit
…changes to skip fialing tests so lets fix in next commit
38e4e20 to
7b196c3
Compare
35f2b09 to
6ea336f
Compare
Base automatically changed from
async-connect-context-manager-support
to
dev/aio-connector
November 19, 2025 08:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: