Skip to content

NO-SNOW: Preserve use_requests_session for back-compat #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

NO-SNOW: Preserve use_requests_session for back-compat #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f66c9f8
NO-SNOW: Preserve use_requests_session for back-compat
sfc-gh-turbaszek Nov 12, 2025
66a000e
fixup! NO-SNOW: Preserve use_requests_session for back-compat
sfc-gh-turbaszek Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/snowflake/connector/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,3 +1222,6 @@ def _request_exec(

def use_session(self, url: str | bytes) -> Generator[Session, Any, None]:
return self.session_manager.use_session(url)

def use_requests_session(self, url: str | bytes) -> Generator[Session, Any, None]:
return self.use_session(url)
2 changes: 1 addition & 1 deletion src/snowflake/connector/result_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def _download(
and connection.rest.session_manager is not None
):
# If connection was explicitly passed and not closed yet - we can reuse SessionManager with session pooling
with connection.rest.use_session(
with connection.rest.use_requests_session(
request_data["url"]
) as session:
logger.debug(
Expand Down
Loading