Cherrypicks to aio connector part 28 #2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| and not isinstance(self.no_proxy, (str, bytes)) | ||
| ) | ||
| else self.no_proxy | ||
| ), |
Contributor
There was a problem hiding this comment.
We have same code here and in async verion, can we create a helper on SnowflakeConnection class and reuse it in async version?
Contributor
Author
There was a problem hiding this comment.
In next cherrypick-PRs this code is changed in synch version (and actually extracted to a separate variable). So I would like to minimise such refactor changes here for now to avoid conflicts - it can be done after the final merge since we have vast number of such duplication.
sfc-gh-turbaszek
approved these changes
Nov 13, 2025
Contributor
sfc-gh-turbaszek
left a comment
sfc-gh-turbaszek
left a comment
There was a problem hiding this comment.
Small comments, but otherwise looks good to me
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-27
branch
from
d7bbc8a to
797fa33
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
bf2d970 to
26eacf2
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-27
branch
from
797fa33 to
6e870c0
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
26eacf2 to
0b14cb3
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-27
branch
from
6e870c0 to
62a635e
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
0b14cb3 to
92121a5
Compare
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
007bd79 to
205f86d
Compare
sfc-gh-turbaszek
approved these changes
Nov 19, 2025
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
87d40e6 to
e67c9b6
Compare
Base automatically changed from
cherrypicks-to-aio-connector-part-27
to
dev/aio-connector
November 21, 2025 12:53
(cherry picked from commit 9c9be36)
# Conflicts: # src/snowflake/connector/aio/_session_manager.py
sfc-gh-fpawlowski
force-pushed
the
cherrypicks-to-aio-connector-part-28
branch
from
e67c9b6 to
aa41aa1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: