SNOW-UD: Add inline UD test workflow and tox connector-swap support by sfc-gh-fpawlowski · Pull Request #4117 · snowflakedb/snowpark-python

sfc-gh-fpawlowski · 2026-03-12T18:37:35Z

Add ud-inline-tests.yml (workflow_dispatch only) to run Snowpark tests against the universal-driver Python connector installed from git+https.
Extend tox_install_cmd.sh with ud_connector_path branch: installs all deps, removes snowflake-connector-python, installs UD in its place.
Add ud_connector_path to tox.ini passenv so the variable reaches the install script.

No behavior change for regular Snowpark CI (ud_connector_path unset falls through to existing snowflake_path / PyPI logic).

Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
- I am adding a new automated test(s) to verify correctness of my new code
  - If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
- I am adding new logging messages
- I am adding a new telemetry message
- I am adding new credentials
- I am adding a new dependency
- If this is a new feature/behavior, I'm adding the Local Testing parity changes.
- I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
- If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
Please describe how your code solves the related issue.

Please write a short description of how your code change solves the related issue.

sfc-gh-aling · 2026-03-12T22:43:26Z

+      python-version:
+        description: 'Python version'
+        required: false
+        default: '3.10'


is it only running one version at a time? should we consider default to the latest available python version in snowflake (3.13/3.14)?

Yes, for now we need it mostly to detect the API drift between both products. When we have solved all the missing contract elements, we can consider a full testing matrix.

And nice catch - changed to 3.13 : )

- Add ud-inline-tests.yml (workflow_dispatch only) to run Snowpark tests against the universal-driver Python connector installed from git+https. - Add scripts/ud_tox_install_cmd.sh — wrapper that delegates to the standard tox_install_cmd.sh, then swaps snowflake-connector-python for the UD connector. Original install script is untouched. - Add [testenv:ud] and [testenv:ud-datasource] to tox.ini with their own install_command, passenv, and setenv. No changes to [testenv]. No behavior change for regular Snowpark CI — UD install logic is fully isolated in the new wrapper script and testenv sections. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

TODO: remove pull_request trigger once all tests are passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Move the Universal Driver connector swap logic into the shared tox_install_cmd.sh (conditional on ud_connector_path) so the UD workflow runs the same tox environments as normal CI instead of dedicated ud/ud-datasource envs. - Add UD swap block to scripts/tox_install_cmd.sh (no-op when unset) - Add ud_connector_path to [testenv] passenv - Remove [testenv:ud] and [testenv:ud-datasource] from tox.ini - Delete scripts/ud_tox_install_cmd.sh - Workflow now invokes py${VER}-notdoctest-ci and datasource directly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace the appended swap block with a proper 3-way conditional: ud_connector_path → snowflake_path → PyPI (in priority order). The appended approach ran the full PyPI install then the swap as a separate pass on every tox install_command invocation. The integrated approach mirrors the original design: UD takes explicit priority, snowflake_path is only used when UD is not set, and a single logical path runs per invocation. Also removes the decorative comment banners added by the previous edit, which were inconsistent with the surrounding code style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Add 'Run doctest' step using py${PYTHON_VERSION}-doctest-notudf-ci, matching the pattern from daily_precommit.yml. - Change default python-version input from 3.10 to 3.13 (latest Snowflake-supported Python). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sfc-gh-joshi · 2026-03-13T22:05:02Z

+          curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
+          curl https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/prod.list \


Is there a safer way to install these than curling from an external URL?

github-actions · 2026-04-22T09:56:31Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

codecov-commenter · 2026-04-22T10:52:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (0aeccd9) to head (a01f5d6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4117   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         171      171           
  Lines       43786    43786           
  Branches     7502     7502           
=======================================
  Hits        41778    41778           
  Misses       1227     1227           
  Partials      781      781

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

graphite-app · 2026-04-22T17:38:52Z

+  PYTHON_VERSION: ${{ inputs.python-version || '3.13' }}
+  CLOUD_PROVIDER: ${{ inputs.cloud-provider || 'aws' }}
+  UD_BRANCH: ${{ inputs.ud-branch || 'snowpark-compatibility' }}
+  EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts || '-v --tb=long' }}


The default value for EXTRA_PYTEST_ADDOPTS is '-v --tb=long', not an empty string. This causes the conditionals at lines 99 and 109 (if: ${{ env.EXTRA_PYTEST_ADDOPTS == '' }}) to always evaluate to false when using default inputs, skipping the doctest and datasource tests unexpectedly.

Impact: When the workflow is triggered without specifying pytest-addopts, only integration tests run. Doctest and datasource tests are always skipped.

Fix: Change the default to empty string:

EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts || '' }}

Or update the conditionals to check for the specific default value, though an empty default is cleaner.

Suggested change

EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts || '-v --tb=long' }}

EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts || '' }}

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

sfc-gh-fpawlowski self-assigned this Mar 12, 2026

sfc-gh-fpawlowski force-pushed the ud-ci-workflow branch from 85594b2 to 178ab95 Compare March 12, 2026 18:55

sfc-gh-fpawlowski added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 12, 2026

sfc-gh-aling reviewed Mar 12, 2026

View reviewed changes

Comment thread .github/workflows/ud-inline-tests.yml

sfc-gh-aling reviewed Mar 12, 2026

View reviewed changes

sfc-gh-fpawlowski marked this pull request as ready for review March 13, 2026 06:04

sfc-gh-fpawlowski requested review from a team as code owners March 13, 2026 06:04

sfc-gh-fpawlowski requested review from sfc-gh-bkogan, sfc-gh-helmeleegy, sfc-gh-jrose, sfc-gh-nkumar and sfc-gh-yixie March 13, 2026 06:04

sfc-gh-fpawlowski and others added 5 commits March 13, 2026 06:40

SNOW-UD: Temporarily enable pull_request trigger for UD workflow

c006e1f

TODO: remove pull_request trigger once all tests are passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sfc-gh-fpawlowski force-pushed the ud-ci-workflow branch from cb7b143 to 44cf53e Compare March 13, 2026 06:43

sfc-gh-aling approved these changes Mar 13, 2026

View reviewed changes

sfc-gh-fpawlowski added 2 commits March 13, 2026 21:33

PULL REQUEST REMOVED

676f375

Merge branch 'main' into ud-ci-workflow

e5e450b

sfc-gh-joshi reviewed Mar 13, 2026

View reviewed changes

sfc-gh-joshi approved these changes Mar 13, 2026

View reviewed changes

sfc-gh-fpawlowski added 2 commits March 22, 2026 12:47

Merge branch 'main' into ud-ci-workflow

ca2ee23

Merge branch 'main' into ud-ci-workflow

95bec17

added pytest options override

a01f5d6

graphite-app Bot reviewed Apr 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SNOW-UD: Add inline UD test workflow and tox connector-swap support#4117

SNOW-UD: Add inline UD test workflow and tox connector-swap support#4117
sfc-gh-fpawlowski wants to merge 10 commits intomainfrom
ud-ci-workflow

sfc-gh-fpawlowski commented Mar 12, 2026

Uh oh!

Uh oh!

sfc-gh-aling Mar 12, 2026

Uh oh!

sfc-gh-fpawlowski Mar 13, 2026

Uh oh!

sfc-gh-joshi Mar 13, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

codecov-commenter commented Apr 22, 2026 •

edited

Loading

Uh oh!

graphite-app Bot Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		curl https://packages.microsoft.com/keys/microsoft.asc \| sudo apt-key add -
		curl https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/prod.list \

	EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts \|\| '-v --tb=long' }}
	EXTRA_PYTEST_ADDOPTS: ${{ inputs.pytest-addopts \|\| '' }}

Conversation

sfc-gh-fpawlowski commented Mar 12, 2026

Uh oh!

Uh oh!

sfc-gh-aling Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

sfc-gh-fpawlowski Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

sfc-gh-joshi Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

codecov-commenter commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Apr 22, 2026 •

edited

Loading