Skip to content

Run tests for PR#4178#4189

Open
sfc-gh-joshi wants to merge 10 commits intomainfrom
joshi-test-SNOW-1897976
Open

Run tests for PR#4178#4189
sfc-gh-joshi wants to merge 10 commits intomainfrom
joshi-test-SNOW-1897976

Conversation

@sfc-gh-joshi
Copy link
Copy Markdown
Contributor

@sfc-gh-joshi sfc-gh-joshi commented Apr 20, 2026

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

It seems like key-pair auth no longer allows external contributors to run CI tests (see #4150 for a similar workaround).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 3 committers have signed the CLA.
✅ (sfc-gh-joshi)[https://github.com/sfc-gh-joshi]
@TimotheeMesnardCH
@Tijoxa
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (7601197) to head (315e3bb).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4189       +/-   ##
===========================================
- Coverage   95.41%   84.81%   -10.61%     
===========================================
  Files         171      170        -1     
  Lines       43801    43713       -88     
  Branches     7505     7505               
===========================================
- Hits        41794    37073     -4721     
- Misses       1227     5441     +4214     
- Partials      780     1199      +419     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-joshi sfc-gh-joshi marked this pull request as ready for review April 21, 2026 22:10
@sfc-gh-joshi sfc-gh-joshi requested review from a team as code owners April 21, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants