Ud ci workflow auto triggered full#4195
Draft
sfc-gh-fpawlowski wants to merge 15 commits intomainfrom
Draft
Conversation
- Add ud-inline-tests.yml (workflow_dispatch only) to run Snowpark tests against the universal-driver Python connector installed from git+https. - Add scripts/ud_tox_install_cmd.sh — wrapper that delegates to the standard tox_install_cmd.sh, then swaps snowflake-connector-python for the UD connector. Original install script is untouched. - Add [testenv:ud] and [testenv:ud-datasource] to tox.ini with their own install_command, passenv, and setenv. No changes to [testenv]. No behavior change for regular Snowpark CI — UD install logic is fully isolated in the new wrapper script and testenv sections. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TODO: remove pull_request trigger once all tests are passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the Universal Driver connector swap logic into the shared
tox_install_cmd.sh (conditional on ud_connector_path) so the UD
workflow runs the same tox environments as normal CI instead of
dedicated ud/ud-datasource envs.
- Add UD swap block to scripts/tox_install_cmd.sh (no-op when unset)
- Add ud_connector_path to [testenv] passenv
- Remove [testenv:ud] and [testenv:ud-datasource] from tox.ini
- Delete scripts/ud_tox_install_cmd.sh
- Workflow now invokes py${VER}-notdoctest-ci and datasource directly
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the appended swap block with a proper 3-way conditional: ud_connector_path → snowflake_path → PyPI (in priority order). The appended approach ran the full PyPI install then the swap as a separate pass on every tox install_command invocation. The integrated approach mirrors the original design: UD takes explicit priority, snowflake_path is only used when UD is not set, and a single logical path runs per invocation. Also removes the decorative comment banners added by the previous edit, which were inconsistent with the surrounding code style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add 'Run doctest' step using py${PYTHON_VERSION}-doctest-notudf-ci,
matching the pattern from daily_precommit.yml.
- Change default python-version input from 3.10 to 3.13 (latest
Snowflake-supported Python).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 676f375.
Allow filtering which tests run via workflow_dispatch by passing extra pytest arguments (e.g. -k, --maxfail). Doctest and datasource steps are automatically skipped when a filter is active. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Default the pytest-addopts filter to a single representative test file while we iterate on UD compatibility. Remove the default once the full suite passes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
workflow_dispatch defaults don't apply on pull_request triggers, so move the temporary test subset fallback into the env var resolution where it covers both trigger types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
File paths in PYTEST_ADDOPTS don't restrict collection when tox already passes `tests` as a positional arg. Use -k filtering instead, with -v --tb=long -x for immediate verbose feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Remove -k filter and -x to get a complete picture of all UD connector failures in one run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
- Coverage 95.41% 95.17% -0.25%
==========================================
Files 171 171
Lines 43786 43786
Branches 7502 7502
==========================================
- Hits 41778 41672 -106
- Misses 1227 1293 +66
- Partials 781 821 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.