Filter traces based on dependency key and value#29
Open
aherrmann wants to merge 1 commit intosnowleopard:mainfrom
Open
Filter traces based on dependency key and value#29aherrmann wants to merge 1 commit intosnowleopard:mainfrom
aherrmann wants to merge 1 commit intosnowleopard:mainfrom
Conversation
Previously `deepDependencies` filtered the traces by comparing a the trace's key against dependency keys but comparing the trace's value against the current top-level value. This changes `recordDCT` to invoke `deepDependencies` on the dependencies' keys and value hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the implementation of deep constructive traces I couldn't make sense of the way in which
deepDependencieswas applied:It filtered the traces by comparing the trace's key against the dependency's key but comparing the trace's value against the current top-level value.
I think it should compare against the dependency's key and value. Though I may be misunderstanding something.