feat: add pages_dir config and output_dir safety guard#4
Merged
lucasnevespereira merged 2 commits intomainfrom Apr 26, 2026
Merged
feat: add pages_dir config and output_dir safety guard#4lucasnevespereira merged 2 commits intomainfrom
lucasnevespereira merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes around build paths:
Guard against unsafe
output_dir. Previous behavior wouldos.RemoveAllwhatever path you pointedoutput_dirat — setting it to.would delete the entire project on first build. NewvalidateOutput()rejects:output_direqual to the project rootoutput_diroutside the project tree (../escape)Configurable
pages_dir. Was hardcoded topages/. Now overridable viaink.yaml:Defaults to
pages/. Useful when migrating from layouts that already have asrc/convention.Test plan
go vet ./...cleango build ./...cleanoutput_dir: "."with a clear errorpages_dir: srcresolves correctly when content lives atsrc/<page>/content.md