Bump wai-app-static upper bound to include 3.2.x#330
Open
jappeace-sloth wants to merge 8 commits intosnoyberg:masterfrom
Open
Bump wai-app-static upper bound to include 3.2.x#330jappeace-sloth wants to merge 8 commits intosnoyberg:masterfrom
jappeace-sloth wants to merge 8 commits intosnoyberg:masterfrom
Conversation
Raise the upper bound from <3.2 to <3.3 so the latest wai-app-static 3.2.1 release is accepted. Patch bump version to 2.3.1 and update changelog. Prompt: update keter's wai-app-static bound to include the latest release, don't use || syntax but just < it. patch bump the version and update the changelog too Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jappeace-sloth
force-pushed
the
bump-wai-app-static
branch
from
e06440d to
d102c19
Compare
Add explicit crypton bounds to support upstream RAM changes. This pins the transitive dependency (via tls) to the latest crypton 1.1.x release series. Prompt: in keter change the bounds such that we depend on the lastest crypton release 1.1.0 >= && < 1.2, there is already a PR open to bump bounds, use this one to modify that. This is to support or ram change upstream Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The nixpkgs 25.05 package set has an older crypton that doesn't satisfy the new >=1.1.0 bound. Add a conditional override to pull crypton 1.1.0 from Hackage when needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
callHackageDirect runs cabal2nix which transitively depends on crypton, causing infinite recursion. Use overrideCabal to just swap the version and source hash instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
crypton 1.1.0 has new dependencies (ram, base16) not in nixpkgs. Add ram 0.21.1 from Hackage and include both as extra deps in the crypton overrideCabal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ram is defined in our own overrides, so it must be referenced via the fixed-point (hself), not the previous package set (hprev). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Overriding crypton globally causes infinite recursion because cabal2nix (used by callHackageDirect/callCabal2nix) transitively depends on crypton, creating a cycle. Instead, use doJailbreak so the nix build accepts nixpkgs' crypton 1.0.x while the cabal bounds (>=1.1.0) protect Hackage/cabal users. Remove the jailbreak once nixpkgs updates crypton to >= 1.1.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wai-app-staticupper bound from<3.2to<3.3to include the latest 3.2.1 releaseTest plan
cabal buildsucceeds with the new bounds🤖 Generated with Claude Code