Move Async::HTTP::RelativeLocation to Async::HTTP::Middleware::LocationRedirector.
#174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationRedirector`.
ioquatix
force-pushed
the
rename-relative-location
branch
from
b0795d7 to
0e17401
Compare
| # The request body was already rewindable, so use it as is: | ||
| body = request.body | ||
| else | ||
| # The request body was not rewindable, and we might need to resubmit it if we get a response status of 307 or 308, so make it rewindable: |
There was a problem hiding this comment.
These comments are really good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of the implementation has changed.
Types of Changes
Contribution