Skip to content

record_syscall: Handle ETHTOOL_GLINKSETTINGS correctly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sodar wants to merge 1 commit into
base: rr-with-dpdk-fix-rdma-verbs-ioctl
Choose a base branch
from
Draft

record_syscall: Handle ETHTOOL_GLINKSETTINGS correctly #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/record_syscall.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,9 +1573,20 @@ template <typename Arch> void prepare_ethtool_ioctl(RecordTask* t, TaskSyscallSt
case ETHTOOL_SFEATURES:
break;
// Expected EINVAL for 'ioctl' but got result 0 (errno SUCCESS); unknown ETHTOOL command 76
case ETHTOOL_GLINKSETTINGS:
// TODO(sodar): Handle it somehow?
case ETHTOOL_GLINKSETTINGS: {
auto buf = t->read_mem(buf_ptr.cast<ethtool_link_settings>(), &ok);
if (ok) {
auto nwords = (
buf.link_mode_masks_nwords > 0 ? buf.link_mode_masks_nwords : -buf.link_mode_masks_nwords
);
auto size = ParamSize(sizeof(buf) + sizeof(buf.link_mode_masks[0]) * nwords);
syscall_state.mem_ptr_parameter(payload, size, IN_OUT);
} else {
syscall_state.expect_errno = EFAULT;
return;
}
break;
}
// Expected EINVAL for 'ioctl' but got result 0 (errno SUCCESS); unknown ETHTOOL command 29
case ETHTOOL_GSTATS:
// TODO(sodar): Handle it somehow?
Expand Down