Change data field widget so that it is read-only if there is a parent.#26
Merged
hugtalbot merged 1 commit intosofa-framework:masterfrom Nov 6, 2025
Conversation
In sofa it is possible, to have both a parent in a data (so copying the value on change) as well as the data to be not flag as read-only. This is a very questionnable design that can be fixed either by: - implementing in BaseData::isReadOnly so that it returns true of there is a parent - handle the case in the UI, this avoid do change a core behavior in SOFA I would prefer that we clarify and fix the expected behavior in BaseData. But until then I would support we reflact that in the UI.
bakpaul
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sofa it is possible, to have both a parent in a data (so copying the value on change) as well as the data to be not flag as read-only.
This is a questionnable design that can be fixed either by:
I would prefer that we clarify and fix the expected behavior in BaseData. But until then I would support we reflact that in the UI.
An alternative would be to de-parent when we edit or offer the user the choice.