Skip to content

[Dependency] NFD: use the alias for nfd only if it exists #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugtalbot merged 2 commits into from
Feb 27, 2026
Merged

[Dependency] NFD: use the alias for nfd only if it exists #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c9f5f
Update CMakeLists.txt
fredroy Feb 19, 2026
f7b8714
create nfd::nfd alias if not defined
olivier-roussel Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions SofaImGui/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ elseif( (DEFINED SOFA_ALLOW_FETCH_DEPENDENCIES AND SOFA_ALLOW_FETCH_DEPENDENCIES
)
set_property(TARGET nfd PROPERTY POSITION_INDEPENDENT_CODE ON)
set_target_properties(nfd PROPERTIES LINKER_LANGUAGE CXX)
add_library(nfd::nfd ALIAS nfd) # introduced in nfd >= v1.2.1
endif()
if(TARGET nfd AND NOT TARGET nfd::nfd)
add_library(nfd::nfd ALIAS nfd) # introduced in nfd >= v1.2.1
endif()

# ImPlot
Expand Down Expand Up @@ -151,11 +153,7 @@ add_library(${PROJECT_NAME} SHARED ${HEADER_FILES} ${SOURCE_FILES} ${IMGUI_SOURC
target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${IMGUI_SOURCE_DIR}>")
target_link_libraries(${PROJECT_NAME} PUBLIC SofaGLFW Sofa.GL.Component.Rendering3D ${CMAKE_DL_LIBS})
target_link_libraries(${PROJECT_NAME} PRIVATE SimpleIni::SimpleIni)
if (EXISTS nfd)
target_link_libraries(${PROJECT_NAME} PRIVATE nfd)
else()
target_link_libraries(${PROJECT_NAME} PRIVATE nfd::nfd)
endif()
target_link_libraries(${PROJECT_NAME} PRIVATE nfd::nfd)

# setup the same API exports for imgui
target_compile_definitions(${PROJECT_NAME} PUBLIC IMGUI_API=SOFAIMGUI_API)
Expand Down
Loading