[Core] Start renaming BaseObject to BaseComponent#5794
Closed
alxbilger wants to merge 4 commits intosofa-framework:masterfrom
Closed
[Core] Start renaming BaseObject to BaseComponent#5794alxbilger wants to merge 4 commits intosofa-framework:masterfrom
alxbilger wants to merge 4 commits intosofa-framework:masterfrom
Conversation
Contributor
|
PR accepted |
Contributor
|
The CI says otherwise... |
Contributor
Author
|
Agreed during the dev meeting |
Contributor
Author
|
A lot of For example, the following code used to compile: template<class T>
class DummyComponent : public BaseObject
{
public:
SOFA_CLASS(DummyComponent<T>, BaseObject);
};but the following is working with the compatibility: template<class T>
class DummyComponent : public core::objectmodel::BaseObject
{
public:
SOFA_CLASS(DummyComponent<T>, core::objectmodel::BaseObject);
}; |
cf648dc to
4cf5635
Compare
Contributor
|
There is conflicts here, we could discuss about the plans regarding this PR at the SOFA dev @alxbilger, what you think? |
Contributor
Author
|
Initially, this PR was created as a support to start the discussion. I don't know yet if I will use it or not. |
Contributor
Author
|
Superseded by #5934 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A not-working PR to start the discussion on renaming BaseObject to BaseComponent. It makes more sense for me as we name the classes in the factory 'Component'.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if