Skip to content

[IO] Update MeshVTKLoader so that it can read polydata description of meshes#5821

Open
remibessard wants to merge 6 commits intosofa-framework:masterfrom
remibessard:VTKLoader-polydata-master
Open

[IO] Update MeshVTKLoader so that it can read polydata description of meshes#5821
remibessard wants to merge 6 commits intosofa-framework:masterfrom
remibessard:VTKLoader-polydata-master

Conversation

@remibessard
Copy link
Contributor

@remibessard remibessard commented Dec 11, 2025

Being new in this process I will proobably mixup things...

Here is a small update of the MeshVTKLoader so that it can load polydata vtk files.
This was required for my work in PREMYOM to load OpenSim files.

I hope the compilation goes smoothly. If not, the next step will obviously be to correct these potential errors.

[with-all-tests]
[with-regression-tests][with-scene-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul changed the title UPDATE MeshVTKLoader so that it can read polydata description of meshes [IO] Update MeshVTKLoader so that it can read polydata description of meshes Dec 11, 2025
@fredroy fredroy added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Dec 11, 2025
@hugtalbot
Copy link
Contributor

Hi @remibessard
Just so that you know a new loader (more generic/versatile) has recently been implemented by @alxbilger : https://github.com/SofaDefrost/SOFA.VTK

@hugtalbot hugtalbot added this to the v26.06 milestone Dec 12, 2025
@remibessard
Copy link
Contributor Author

Ha, thx for sharing this information.
of course I did not know, and this was not there last summer when I needed it.
Moreover, I am happy not to add this dependency to VTK.

But I will be happy to use this code when it will replace the VTKLoader in SOFA, that's for sure !

@hugtalbot
Copy link
Contributor

What was discussed previously @remibessard is that this can be integrated into SOFA anyway. The other plugin will later be integrated and possibly replace this code. Would you mind taking the reviews into account?

@hugtalbot hugtalbot requested a review from bakpaul January 24, 2026 13:26
@hugtalbot
Copy link
Contributor

Hi @remibessard I updated your PR but I would need a mesh to test it, would you have some to share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants