[Lifecycle] v26.06 : SOFA_ATTRIBUTE_DISABLED#5888
Merged
fredroy merged 3 commits intosofa-framework:masterfrom Feb 13, 2026
Merged
[Lifecycle] v26.06 : SOFA_ATTRIBUTE_DISABLED#5888fredroy merged 3 commits intosofa-framework:masterfrom
fredroy merged 3 commits intosofa-framework:masterfrom
Conversation
hugtalbot
added
pr: status to review
hugtalbot
added a commit
to sofa-framework/Sofa.Qt
that referenced
this pull request
Jan 27, 2026
Collaborator
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
alxbilger
reviewed
Feb 4, 2026
| bool isValid() const; | ||
| bool isFlat() const; | ||
| bool isNegligeable() const; // !valid || flat | ||
| bool isNegligible() const; // !valid || flat |
Contributor
There was a problem hiding this comment.
In theory, you need to go through a deprecation period...
Contributor
There was a problem hiding this comment.
Let the theory remain a theory 🫶
bakpaul
reviewed
Feb 4, 2026
| @@ -69,13 +54,6 @@ | |||
| SOFA_ATTRIBUTE_DEPRECATED("v24.12", "v25.12", "RegisterObject and the associated implicit registration is being phased out. Use ObjectRegistrationData and explicit registration from now on. See #4429 for more information.") | |||
Contributor
There was a problem hiding this comment.
Wouldn't you want to change the disable version ?
| #else | ||
| #define SOFA_HELPER_FILESYSTEM_FINDORCREATEAVALIDPATH_DISABLED() \ | ||
| SOFA_ATTRIBUTE_DISABLED( \ | ||
| "v25.06", "v25.12", "It is not clear that this function works on folders or files. Use ensureFolderExists or ensureFolderForFileExists instead.") |
| bool isValid() const; | ||
| bool isFlat() const; | ||
| bool isNegligeable() const; // !valid || flat | ||
| bool isNegligible() const; // !valid || flat |
Contributor
There was a problem hiding this comment.
Let the theory remain a theory 🫶
hugtalbot
added a commit
to sofa-framework/Sofa.Qt
that referenced
this pull request
Feb 5, 2026
fredroy
force-pushed
the
202601_lifecycle_attribute_disabled_1
branch
from
efda0c1 to
df9c279
Compare
Contributor
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #3. All dependencies are merged/closed. Congrats! 👍 |
fredroy
approved these changes
Feb 13, 2026
fredroy
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stage of the v26.06 LifeCycle : removing disabled attributes
I tried this with Vibe-Mistral but it was not successful !
hopefully we will also drop Sofa.Qt :)
[ci-depends-on https://github.com/sofa-framework/Sofa.Qt/pull/28]
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if