This repository was archived by the owner on Aug 24, 2019. It is now read-only.
Refactor SSFilterableFetchedResultsController filter updates.#21
Open
maxmeyers wants to merge 3 commits intosoffes:masterfrom
Open
Refactor SSFilterableFetchedResultsController filter updates.#21maxmeyers wants to merge 3 commits intosoffes:masterfrom
maxmeyers wants to merge 3 commits intosoffes:masterfrom
Conversation
…ignificant Inserts, Deletes, and Moves.
Owner
|
Thanks! Definitely a better approach. I'll merge when I get a chance to test it. Want to make sure it's solid before releasing. |
Author
|
Cool, thanks! |
… filter in place.
… a filter in place.
Author
|
I added a couple more changes. First, in ab618ca, I added an accessor to get the unfiltered fetchedObjects. This is useful, for example, when there's a filter in place but you still want to know how many objects there are in the total list. Secondly, in 2c5fecc, I did an overhaul of how updates to the objects in the NSFetchedResultsController are propagated to the delegate when a filter is in place. There are logical considerations for each CRUD command that depend on the filter. |
Owner
|
Any chance you can write tests for this stuff? I'd love to have confidence with this junk going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whenever there's an change in the filter in a SSFilterableFetchedResultsController, the entire table is deleted and the new results are filtered.
With this change, only objects that do not pass the new filter are deleted, objects that pass both filters are moved if necessary, and objects that only pass the new filter (but not the old one) are inserted.
Thanks for all your hard work on this project! It seriously helped my understanding and use of CoreData.