Skip to content

Commit 3f83618

Browse files
finishing up tests
1 parent 8a22d39 commit 3f83618

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

SoftLayer/fixtures/SoftLayer_Virtual_Guest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -769,4 +769,4 @@
769769
]
770770

771771
migrate = True
772-
migrateDedicatedHost = True
772+
migrateDedicatedHost = True

SoftLayer/testing/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ def assert_not_called_with(self, service, method, **props):
151151
if self.calls(service, method, **props):
152152
raise AssertionError('%s::%s was called with given properties: %s' % (service, method, props))
153153

154-
155154
def assert_no_fail(self, result):
156155
"""Fail when a failing click result has an error"""
157156
if result.exception:

tests/CLI/modules/vs/vs_tests.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,9 +823,18 @@ def test_vs_migrate_list(self):
823823
self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrate')
824824
self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost')
825825

826+
def test_vs_migrate_list_empty(self):
827+
mock = self.set_mock('SoftLayer_Account', 'getVirtualGuests')
828+
mock.return_value = []
829+
result = self.run_command(['vs', 'migrate'])
830+
self.assert_no_fail(result)
831+
self.assert_called_with('SoftLayer_Account', 'getVirtualGuests')
832+
self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrate')
833+
self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost')
834+
self.assertIn("No guests require migration at this time", result.output)
835+
826836
def test_vs_migrate_guest(self):
827837
result = self.run_command(['vs', 'migrate', '-g', '100'])
828-
829838
self.assert_no_fail(result)
830839
self.assertIn('Started a migration on', result.output)
831840
self.assert_not_called_with('SoftLayer_Account', 'getVirtualGuests')

tests/managers/vs/vs_tests.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,3 +1132,13 @@ def test_get_local_disks_swap(self):
11321132
}
11331133
}
11341134
], result)
1135+
1136+
def test_migrate(self):
1137+
result = self.vs.migrate(1234)
1138+
self.assertTrue(result)
1139+
self.assert_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=1234)
1140+
1141+
def test_migrate_dedicated(self):
1142+
result = self.vs.migrate_dedicated(1234, 5555)
1143+
self.assertTrue(result)
1144+
self.assert_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost', args=(5555,), identifier=1234)

0 commit comments

Comments
 (0)