Be able to configure multiple annotations to add to a pod depending on pod labels#3
Open
santinoncs wants to merge 1 commit intomasterfrom
Open
Be able to configure multiple annotations to add to a pod depending on pod labels#3santinoncs wants to merge 1 commit intomasterfrom
santinoncs wants to merge 1 commit intomasterfrom
Conversation
Member
|
Could you explain why do we need this? |
Member
Author
Maybe in some cases we want to include another annotation depending on the labels. as we don't want the cluster autoscaler to evict it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old config:
new config:
It will apply the example.com/some-annotation: "true" annotation to pods with the annotation-type label set to some-label-value.