chore(gradle): remove custom startScripts task #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jar task was resolving the default configuration in the configuration phase, leading to spurious failure when executing any task in the testclient directly.
It was only because of two constants...
Current issues: - the start-script hardcodes classpath to lib: gradle/gradle#7033 - script assumes it is in a bin directory, but I want it in root ("pwd -P") https://docs.gradle.org/current/dsl/org.gradle.jvm.application.tasks.CreateStartScripts.html
xeruf
added
action:investigate
Thompson1985
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening of #369
Current issues:
gradle application plugin startScripts: add custom directory to classpath is almost impossible gradle/gradle#7033
https://docs.gradle.org/current/dsl/org.gradle.jvm.application.tasks.CreateStartScripts.html
May fix #265