Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds ReSharper settings for the project and introduces support for Blazor applications by adding an IsRunningBlazor option to BrowserWindowOptions. The version is bumped from 0.1.0 to 0.2.0 across all relevant files.
Key Changes:
- Added ReSharper configuration file with code formatting settings
- Introduced
IsRunningBlazorproperty to disable conflicting globals for Blazor - Added
blazor-preload.jsscript to undefineprocessandmoduleglobals - Reformatted TypeScript/JavaScript files to use double quotes consistently
- Updated version references from 0.1.0 to 0.2.0 across the codebase
Reviewed Changes
Copilot reviewed 14 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET.sln.DotSettings | Adds ReSharper code formatting settings |
| src/common.props | Bumps version to 0.2.0 |
| src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | Updates package references to version 0.2.0 |
| src/ElectronNET.Host/scripts/blazor-preload.js | New preload script to disable globals for Blazor |
| src/ElectronNET.Host/api/browserWindows.ts | Implements IsRunningBlazor feature with preload script injection |
| src/ElectronNET.Host/api/webContents.ts | Code formatting changes (single to double quotes) |
| src/ElectronNET.Host/api/*.js.map | Updated source maps for reformatted JavaScript files |
| src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj | Updates package reference to version 0.2.0 |
| src/ElectronNET.API/API/Entities/BrowserWindowOptions.cs | Adds IsRunningBlazor property |
| docs/GettingStarted/Console-App.md | Updates documentation with new version |
| Changelog.md | Documents the new feature in version 0.2.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,7 @@ | |||
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | |||
There was a problem hiding this comment.
The XML namespace URL contains a typo: "shemas-jetbrains-com" should be "schemas-jetbrains-com" (missing 'c' in "schemas").
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | |
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:schemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> |
| const path = require('path'); | ||
| const windows: Electron.BrowserWindow[] = (global['browserWindows'] = global['browserWindows'] || []) as Electron.BrowserWindow[]; | ||
| import { Socket } from "net"; | ||
| import { BrowserWindow, Menu, nativeImage } from "electron"; |
There was a problem hiding this comment.
Unused import nativeImage.
| import { BrowserWindow, Menu, nativeImage } from "electron"; | |
| import { BrowserWindow, Menu } from "electron"; |
| windowItem.id; | ||
| } catch (error) { | ||
| if (error.message === "Object has been destroyed") { | ||
| windows.splice(index, 1); |
There was a problem hiding this comment.
Removing an array item without adjusting the loop index 'index' causes the subsequent array item to be skipped.
| windows.splice(index, 1); | |
| windows.splice(index, 1); | |
| index--; |
febf57c to
31a5bae
Compare
31a5bae to
c554673
Compare
No description provided.