Skip to content

Conversation

@sogaiu
Copy link
Owner

@sogaiu sogaiu commented Jul 15, 2025

This PR is an attempt to address #67.

It contains some corpus tests for:

param-tags-metadata.txt currently packages things to be tested all as a single test. This might be unwieldy if we need to examine output.

May be the way things are grouped here isn't a bad way to organize things...

@sogaiu sogaiu force-pushed the clojure-1.12-syntax-tests branch from 12bf19b to 059d244 Compare July 16, 2025 00:52
@sogaiu
Copy link
Owner Author

sogaiu commented Jul 16, 2025

Went with a different grouping that seemed more sensible for the context of parsing.

@sogaiu
Copy link
Owner Author

sogaiu commented Jul 16, 2025

Adding a note here about how the built-in testing system has some unfortunate drawbacks.

One of those is the multistep manual flow involved in examining the original input to the test. AFAIU, the input for a test is not displayed even when the test errors.

In addition, the name / location of the file that contains the test is not really "physically" close to where the error details are reported in the output.

The process of looking up the input to a failed test is on the unsatisfactory side [1].

For reference there is this comment at the tree-sitter repository that also touches on some related bits.


[1] The flow is roughly like:

  1. Notice some red in the output
  2. Find out which test number (and test name) that is associated with
  3. Scroll up to find which test file name (actually without extension) contains the relevant test
  4. Navigate to the relevant test file
  5. Search the test file using the test name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants