Skip to content

[shortcuts] optionality to unbind shortcuts#210

Open
kyan-yang wants to merge 2 commits intosohzm:masterfrom
kyan-yang:unbind-shortcut
Open

[shortcuts] optionality to unbind shortcuts#210
kyan-yang wants to merge 2 commits intosohzm:masterfrom
kyan-yang:unbind-shortcut

Conversation

@kyan-yang
Copy link

@kyan-yang kyan-yang commented Feb 9, 2026

added option to unbind a shortcut by pressing an x button.
prettier auto formatting formatted some stuff, but its dtm to put that in a separate pr so i just left it in

Summary by CodeRabbit

  • New Features
    • Added the ability to unbind individual keyboard shortcuts. A clear button now appears next to each keybind input for easy removal.
    • Enhanced keyboard shortcuts interface with visual indicators showing bound and unbound states, plus placeholder text for unbound shortcuts.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

A new clearKeybind method and corresponding UI elements enable users to unbind keyboard shortcuts in the CustomizeView. Each keybind row now displays an unbind button that resets the keybind to an empty state when clicked. Minor rendering adjustments were made for consistent layout and spacing.

Changes

Cohort / File(s) Summary
Keybind Unbinding Feature
src/components/views/CustomizeView.js
Added clearKeybind(action) method to reset specific keybinds. Introduced UI unbind buttons next to each keybind input with styling and hover behavior, visible only when a keybind is set. Integrated per-action unbind logic into Keyboard Shortcuts section rendering with minor formatting adjustments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A button to unbind, so clean and so neat,

Keybinds now vanish without a repeat,

Press once to clear what was set with a key,

Customize flows now with flexibility! 🎹✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[shortcuts] optionality to unbind shortcuts' clearly describes the main change: adding the ability to unbind keyboard shortcuts. It is specific, concise, and directly relates to the primary functionality added in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
src/components/views/CustomizeView.js (1)

684-710: Inline styles on the wrapper div — consider extracting to a CSS class.

Line 688 uses style="display:flex;gap:4px;align-items:center;" and line 702 uses inline visibility. While functional, extracting these into a named CSS class (e.g., .keybind-actions) would be more consistent with the rest of the component's CSS-in-static styles approach.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant