update editorjs and selector-element.js to position selector element properly#33
Open
AadiXC0DE wants to merge 5 commits intosohzm:masterfrom
Open
update editorjs and selector-element.js to position selector element properly#33AadiXC0DE wants to merge 5 commits intosohzm:masterfrom
AadiXC0DE wants to merge 5 commits intosohzm:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Owner
|
so remove so much of the spacing and padding |
Author
on it! |
Author
Owner
|
nice job, will review and merge today :) |
Owner
Author
|
yup, taking a look for columns and nested elements it's slightly tricky, tons of edge cases and elements to cover |
…t selector positioning
Author
Screen.Recording.2025-08-19.at.10.21.04.PM.mov |
Owner
|
can you checkout the cla section of the contribution.md for cla make its input focused when shown and also what happened at 0:20 in video? why did it scroll? |
Author
Screen.Recording.2025-08-20.at.2.42.39.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




CLA
I have read and agree to the Contributor License Agreement in CLA.md.
I agree to the CLA.
Screen.Recording.2025-08-19.at.1.40.37.PM.mov