Skip to content

update editorjs and selector-element.js to position selector element properly#33

Open
AadiXC0DE wants to merge 5 commits intosohzm:masterfrom
AadiXC0DE:ac/selector-fix
Open

update editorjs and selector-element.js to position selector element properly#33
AadiXC0DE wants to merge 5 commits intosohzm:masterfrom
AadiXC0DE:ac/selector-fix

Conversation

@AadiXC0DE
Copy link

@AadiXC0DE AadiXC0DE commented Aug 19, 2025

CLA
I have read and agree to the Contributor License Agreement in CLA.md.
I agree to the CLA.

Screen.Recording.2025-08-19.at.1.40.37.PM.mov

@vercel
Copy link

vercel bot commented Aug 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
wisk Ready Ready Preview Comment Aug 19, 2025 9:15pm

@AadiXC0DE AadiXC0DE marked this pull request as ready for review August 19, 2025 09:52
@sohzm
Copy link
Owner

sohzm commented Aug 19, 2025

also have to update the ui as such (see notion for example)

image

@sohzm
Copy link
Owner

sohzm commented Aug 19, 2025

so remove so much of the spacing and padding

@AadiXC0DE
Copy link
Author

so remove so much of the spacing and padding

on it!

@AadiXC0DE
Copy link
Author

image image

@sohzm
Copy link
Owner

sohzm commented Aug 19, 2025

nice job, will review and merge today :)

@sohzm
Copy link
Owner

sohzm commented Aug 19, 2025

few things

  • you need to handle elements that are nested in the base-layout-element and columns element (ie you need to do a deeper search that searches for nested shadowroot elements as well)
  • we want users to not have to more eye a lot so it should position itself such that the input field is in the same line as the plus was clicked, see ive added notion ss for example
image

@AadiXC0DE
Copy link
Author

yup, taking a look
placing the selector just near '+' seems easy

for columns and nested elements it's slightly tricky, tons of edge cases and elements to cover
pushing a commit with fixes soon!

@AadiXC0DE
Copy link
Author

Screen.Recording.2025-08-19.at.10.21.04.PM.mov

@sohzm
Copy link
Owner

sohzm commented Aug 19, 2025

can you checkout the cla section of the contribution.md for cla

make its input focused when shown and also what happened at 0:20 in video? why did it scroll?

@AadiXC0DE
Copy link
Author

  • added the cla in description
  • fixed the input focus issue
  • not sure about the scroll issue, unable to reproduce it again
Screen.Recording.2025-08-20.at.2.42.39.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move the selector element from center to the position near the plus sign, like how the context menu works rn

2 participants