NUI 6263 search component accessibility#801
Conversation
| (click)="onSearch()" | ||
| ></button> | ||
| </div> | ||
| <input |
There was a problem hiding this comment.
will it cause the possible regression? visually it looks the same? I bet the e2e, ui tests may be broken
There was a problem hiding this comment.
Visually, it is ok
If you mean tests in CircleCI, they passed...
pavlo-poimanov
left a comment
pavlo-poimanov
left a comment
There was a problem hiding this comment.
image/popup/repeat should be fine but the search I'm not sure this changes will not cause problems. double check if all fine then ok.
also you can be a good camper and do next:
- make this true standalone components
- rewrite to signals control flow
- ngDestory => destroyRef
- inject() function
first camp fire rule - leave place better than it was before you ;)
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
db8d179 to
a7cca60
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
a7cca60 to
02e3e7d
Compare
| } | ||
|
|
||
| @HostListener("keydown", ["$event"]) | ||
| public handleKeydown(event: KeyboardEvent): void { |
There was a problem hiding this comment.
I do think this caused the regression on the menu.
On the keydown enter it had to do ckeckbox checking. See the test.
There was a problem hiding this comment.
in test it waits the menu still be opened
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
20f738e to
3f1c29d
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
3f1c29d to
ef1531c
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
ef1531c to
fbe421d
Compare
2 participants
https://swicloud.atlassian.net/browse/NUI-6263
ER:
The Search button opens a pop-up when the Spacebar key is pressed.
The expanded search bar closes when the Esc key is pressed.
The buttons have sufficient contrast when focused.
The cancel button next to the Search bar is focusable by the Tab key and is called “Clear search button”
The magnifier icon next to the Search bar is hidden for the screen reader.
The buttons in the “Recent searches” area are accessible by the Tab key. I can get to the search by pressing the Enter or Space bar key. The caret-right icon is hidden.
When returning to some text in the search field, I hear: “Search edit selected all”
https://swicloud.atlassian.net/browse/OO-55517
ER:
The icon will be hidden for the SR. There will be no error in AXE DevTool.
Checklist