Skip to content

feat: design qa multi theming improvements#2751

Merged
auroraVasconcelos merged 132 commits intomainfrom
feat/design-qa-multi-theming
Apr 10, 2026
Merged

feat: design qa multi theming improvements#2751
auroraVasconcelos merged 132 commits intomainfrom
feat/design-qa-multi-theming

Conversation

@auroraVasconcelos
Copy link
Copy Markdown
Contributor

@auroraVasconcelos auroraVasconcelos commented Jan 20, 2026

Description:

Closes #2787, closes #2739, closes #2789, closes #2740, closes #2815, closes #2805, closes #2735, closes #2614

  • Add css properties section to docs table in styles

To avoid breaking changes there are currently two types of fallbacks:

  • Newer tokens than components/styles (e.g., tokens on Solid v6.1.0 and components/styles on Solid v6.0.0):
    Fallbacks for removed variables are provided in variables-legacy.css.
  • Older tokens than components/styles (e.g., tokens on Solid v6.0.0 and components/styles on Solid v6.1.0):
    Additional fallbacks were introduced for CSS variables that support custom themes. These variables are marked as deprecated in the documentation, and users are encouraged to stop using them. They will be removed in a future version of Solid to ensure a more robust and maintainable codebase.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: 436ebee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@solid-design-system/styles Minor
@solid-design-system/docs Patch
@solid-design-system/tokens Minor
@solid-design-system/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 20, 2026

🚀 Storybook has been deployed for branch feat_design-qa-multi-theming

@coraliefeil coraliefeil moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Jan 21, 2026
@coraliefeil
Copy link
Copy Markdown
Contributor

@van-nguyen-ht qa can be done as soon as chromatic is available. Let’s quickly talk when this is ready.

@coraliefeil
Copy link
Copy Markdown
Contributor

@auroraVasconcelos could we generate screenshots onto which we can put comments where adjustments need to be made?

@karlbaumhauer karlbaumhauer linked an issue Mar 31, 2026 that may be closed by this pull request
4 tasks
Comment thread packages/components/src/components/accordion/accordion.ts Outdated
Comment thread packages/components/src/components/checkbox/checkbox.ts
Comment thread packages/components/src/components/menu/menu.ts
Comment thread packages/components/src/components/step/step.ts
Comment thread packages/docs/.storybook/preview-head.html
Comment thread packages/docs/scripts/storybook/deprecated-badge-enhancer.js
Comment thread packages/docs/src/stories/templates/breadcrumb.stories.ts
Comment thread packages/styles/src/modules/flag.css Outdated
Comment thread packages/tokens/themes/kid/kid.css Outdated
Comment thread packages/tokens/CONTRIBUTING.md Outdated
Comment thread packages/tokens/CONTRIBUTING.md Outdated
Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
mariohamann
mariohamann previously approved these changes Apr 7, 2026
Comment thread packages/docs/.storybook/preview-head.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment