Skip to content

fix: combobox input delete#2860

Merged
rahulsuvarna18 merged 7 commits intomainfrom
fix/combobox-input-delete
Mar 25, 2026
Merged

fix: combobox input delete#2860
rahulsuvarna18 merged 7 commits intomainfrom
fix/combobox-input-delete

Conversation

@rahulsuvarna18
Copy link
Copy Markdown
Contributor

@rahulsuvarna18 rahulsuvarna18 commented Mar 16, 2026

Description:

closes #2741

Definition of Reviewable:

  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: 64f0767

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@solid-design-system/components" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/styles" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/tokens" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@rahulsuvarna18 rahulsuvarna18 changed the title Fix/combobox input delete fix: combobox input delete Mar 16, 2026
@rahulsuvarna18 rahulsuvarna18 changed the title fix: combobox input delete Fix: combobox input delete Mar 16, 2026
@rahulsuvarna18 rahulsuvarna18 changed the title Fix: combobox input delete fix: combobox input delete Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026

🚀 Storybook has been deployed for branch fix_combobox-input-delete

@coraliefeil
Copy link
Copy Markdown
Contributor

Like discussed with Rahul ... position of text cursor is fine now

Copy link
Copy Markdown
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have identified a new bug in the input. is also wrong in production so we need to open a ticket. can you do it please? outside this ticket.

Image

to reproduce:

  1. click in input
  2. select one of the suggestions
    you will see the result above.

@tega-ekakitie
Copy link
Copy Markdown

@rahulsuvarna18 tested Okay

@smfonseca
Copy link
Copy Markdown
Collaborator

smfonseca commented Mar 19, 2026

I detected a weird behaviour. If you type "option 1" or "option 2" (notice the lowercase), and press tab, the input is not cleared but the option in the list is also not selected. I also cannot delete the value, only if I type something over. I feel we need to also allow deletion in this case.

Screen.Recording.2026-03-19.at.14.59.20.mov

@tega-ekakitie tega-ekakitie removed their assignment Mar 20, 2026
Copy link
Copy Markdown
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2026-03-19.at.14.59.20.mov

@smfonseca smfonseca removed their assignment Mar 24, 2026
@rahulsuvarna18 rahulsuvarna18 merged commit e6b5dd4 into main Mar 25, 2026
19 checks passed
@rahulsuvarna18 rahulsuvarna18 deleted the fix/combobox-input-delete branch March 25, 2026 12:25
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: sd-combobox prevents user from editing text after tab

9 participants