Skip to content

fix: improve live region behavior for screen readers #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balco0110 wants to merge 1 commit into from
Closed

fix: improve live region behavior for screen readers #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wacky-canyons-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solid-design-system/components': patch
---

Fix `sd-carousel` live region behavior for screen readers.
21 changes: 4 additions & 17 deletions packages/components/src/components/carousel/carousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,16 +300,8 @@ export default class SdCarousel extends SolidElement {
this.requestUpdate();
};

private handleFocus() {
if (this.autoplay) {
this.scrollContainer.setAttribute('aria-live', 'polite');
}
}

private handleBlur() {
if (this.autoplay) {
this.scrollContainer.setAttribute('aria-live', 'off');
}
private get isAutoPlaying(): boolean {
return this.autoplay && !this.pausedAutoplay && !this.autoplayController.paused;
}

private unblockAutoplay = (e: MouseEvent, button: HTMLButtonElement) => {
Expand Down Expand Up @@ -620,17 +612,16 @@ export default class SdCarousel extends SolidElement {
: `grid overflow-auto overscroll-x-contain grid-flow-col auto-rows-[100%] snap-x snap-mandatory overflow-y-hidden`
)}"
style="--slides-per-page: ${this.slidesPerPage};"
role="group"
aria-busy="${scrollController.scrolling ? 'true' : 'false'}"
aria-label="${this.localize.term(
'carouselContainer',
Array.from(this.slides).filter(el => !el.hasAttribute('data-clone')).length
)}"
aria-live=${this.autoplay ? 'off' : 'polite'}
aria-live=${this.isAutoPlaying ? 'off' : 'polite'}
tabindex="0"
@keydown=${this.handleKeyDown}
@scrollend=${this.handleScrollEnd}
@focus=${this.handleFocus}
@blur=${this.handleBlur}
>
<slot></slot>
</div>
Expand All @@ -649,8 +640,6 @@ export default class SdCarousel extends SolidElement {
aria-label="${this.localize.term('previousSlide')}"
aria-controls="scroll-container"
aria-disabled="${prevEnabled ? 'false' : 'true'}"
@focus=${this.handleFocus}
@blur=${this.handleBlur}
@click=${prevEnabled
? (e: MouseEvent) => {
this.previous();
Expand Down Expand Up @@ -754,8 +743,6 @@ export default class SdCarousel extends SolidElement {
aria-label="${this.localize.term('nextSlide')}"
aria-controls="scroll-container"
aria-disabled="${nextEnabled ? 'false' : 'true'}"
@focus=${this.handleFocus}
@blur=${this.handleBlur}
@click=${nextEnabled
? (e: MouseEvent) => {
this.next();
Expand Down
Loading