Skip to content

fix: improve live region behavior for screen readers#2865

Merged
balco0110 merged 14 commits intomainfrom
fix/carousel-live-region-should-not-be-activated-when-auto-play-is-active
Apr 22, 2026
Merged

fix: improve live region behavior for screen readers#2865
balco0110 merged 14 commits intomainfrom
fix/carousel-live-region-should-not-be-activated-when-auto-play-is-active

Conversation

@balco0110
Copy link
Copy Markdown
Contributor

@balco0110 balco0110 commented Mar 18, 2026

Description:

Closes: #2412 and #2460

Definition of Reviewable:

  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: aabd644

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@solid-design-system/components Patch
@solid-design-system/styles Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

🚀 Storybook has been deployed for branch fix_carousel-live-region-should-not-be-activated-when-auto-play-is-active

@tega-ekakitie
Copy link
Copy Markdown

@balco0110 Looks good to me
Validated when autoplay is paused and navigated as well as when it's active

@smfonseca
Copy link
Copy Markdown
Collaborator

@balco0110 @tega-ekakitie I've tested in Safari where we usually get better results with VoiceOver, and I'm getting announcements of the image alt text when auto-playis paused which is good. What I noticed is that if I press next or previous in a carousel without auto-play I don't get announcements. Maybe it's connected with the current change, in prod it's working.

I tested on the carousel template page where we have both scenarios.

@balco0110 balco0110 linked an issue Mar 30, 2026 that may be closed by this pull request
4 tasks
@tega-ekakitie tega-ekakitie removed their assignment Apr 8, 2026
@tega-ekakitie
Copy link
Copy Markdown

@balco0110 @tega-ekakitie I've tested in Safari where we usually get better results with VoiceOver, and I'm getting announcements of the image alt text when auto-playis paused which is good. What I noticed is that if I press next or previous in a carousel without auto-play I don't get announcements. Maybe it's connected with the current change, in prod it's working.

I tested on the carousel template page where we have both scenarios.

@balco0110 I checked what @smfonseca mentioned here and it looks good to me now

Comment thread packages/components/src/components/carousel/carousel.ts
Copy link
Copy Markdown
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to create a follow up ticket for the auto-play button announcements. From my perspective, the user should get announcements when starting and pausing the carousel (when a action is performed).

Comment thread .changeset/wacky-canyons-scream.md Outdated
Comment thread packages/components/src/components/carousel/carousel.ts
Comment thread packages/components/src/components/carousel/carousel.ts
Co-authored-by: Sérgio Fonseca <42741644+smfonseca@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balco0110 please keep in mind to create a follow-up ticket for the auto-play button announcements

@balco0110 balco0110 merged commit ec25018 into main Apr 22, 2026
19 checks passed
@balco0110 balco0110 deleted the fix/carousel-live-region-should-not-be-activated-when-auto-play-is-active branch April 22, 2026 06:26
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: 🤔 focus inside carousel not preventing auto scroll fix: 🤔 Carousel's live region should not be activated when auto play is active

7 participants