Skip to content

fix: sd-combobox mobile visual issues#2867

Merged
martascorreia merged 20 commits intomainfrom
fix/combobox-mobile-visual-issues
Apr 8, 2026
Merged

fix: sd-combobox mobile visual issues#2867
martascorreia merged 20 commits intomainfrom
fix/combobox-mobile-visual-issues

Conversation

@martascorreia
Copy link
Copy Markdown
Contributor

@martascorreia martascorreia commented Mar 19, 2026

Description:

closes: #2862

Fixed the mobile view responsiveness of sd-combobox when using multiple tags. Similiar issue as #2749.

Fixed the sd-combobox mobile issues related to clipping. The clipping was related to the container of the stories, not the component itself. However, for testing purposes when developing these components, it would be nice that all of these stories also work in mobile. Therefore, I created this ticket to fix all the other components: #2866.

The other main issue was the grey background that appeared in mobile, which was the hover taking over. I fixed this issue for all the forms components: sd-combobox, sd-input, sd-select, sd-datepicker and sd-textarea.

Definition of Reviewable:

  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: 3f231e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@solid-design-system/components Patch
@solid-design-system/docs Patch
@solid-design-system/styles Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@martascorreia martascorreia changed the title Fix/combobox mobile visual issues fix: sd-combobox mobile visual issues Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

🚀 Storybook has been deployed for branch fix_combobox-mobile-visual-issues

@martascorreia martascorreia self-assigned this Mar 19, 2026
@martascorreia martascorreia moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Mar 19, 2026
@martascorreia martascorreia added Development needs changes in code and removed Development needs changes in code labels Mar 19, 2026
@martascorreia martascorreia moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Mar 19, 2026
@martascorreia martascorreia moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Mar 19, 2026
@coraliefeil
Copy link
Copy Markdown
Contributor

Gray background when active seems to be fixed.
Clipping and alignment still not working.

Pls reassign when fixed

@martascorreia martascorreia moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: 🤔 sd-combobox – visual issues on mobile (background, clipping, alignment)

9 participants