fix: sd-combobox mobile visual issues#2867
Merged
martascorreia merged 20 commits intomainfrom Apr 8, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 3f231e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🚀 Storybook has been deployed for branch |
4 tasks
Contributor
|
Gray background when active seems to be fixed. Pls reassign when fixed |
MartaPintoTeixeira
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
closes: #2862
Fixed the mobile view responsiveness of
sd-comboboxwhen using multiple tags. Similiar issue as #2749.Fixed the
sd-comboboxmobile issues related to clipping. The clipping was related to the container of the stories, not the component itself. However, for testing purposes when developing these components, it would be nice that all of these stories also work in mobile. Therefore, I created this ticket to fix all the other components: #2866.The other main issue was the grey background that appeared in mobile, which was the hover taking over. I fixed this issue for all the forms components:
sd-combobox,sd-input,sd-select,sd-datepickerandsd-textarea.Definition of Reviewable: