Skip to content

fix: combobox focus trap#2880

Merged
rahulsuvarna18 merged 5 commits intomainfrom
fix/combobox-focus
Apr 8, 2026
Merged

fix: combobox focus trap#2880
rahulsuvarna18 merged 5 commits intomainfrom
fix/combobox-focus

Conversation

@rahulsuvarna18
Copy link
Copy Markdown
Contributor

@rahulsuvarna18 rahulsuvarna18 commented Mar 30, 2026 •
edited
Loading

Description:

Closes #2734

Definition of Reviewable:

  • E2E tests (features, a11y, bug fixes) are created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 32de213

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@solid-design-system/components Patch
@solid-design-system/styles Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rahulsuvarna18 rahulsuvarna18 moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026 •
edited
Loading

🚀 Storybook has been deployed for branch fix_combobox-focus

@tega-ekakitie
Copy link
Copy Markdown

tega-ekakitie commented Mar 30, 2026

@rahulsuvarna18 looks good to me

@tega-ekakitie tega-ekakitie removed their assignment Mar 30, 2026
MartaPintoTeixeira
MartaPintoTeixeira previously approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good for me.

But at the moment sd-select and sd-combobox have 2 diffrent behaviours.
They should be both the same.

On sd-select once dropdown is open if I press tab it should 1st close but still be active and only then jump to "Show code" (as you did in sd-combobox and as it is in sd-menu)

If this is a quick fix can you fix sd-select on this small thing please?
If is time consuming consider it approved and please open a ticket for sd-select.

@rahulsuvarna18
Copy link
Copy Markdown
Contributor Author

rahulsuvarna18 commented Mar 31, 2026

Thanks for bringing the issue with the sd-select up. As spoken over our call, I would create a new ticket for it and work on it there. :)

mariohamann
mariohamann reviewed Apr 1, 2026
View reviewed changes
Comment thread packages/docs/src/stories/packages/tokens/Installation.mdx
mariohamann
mariohamann previously requested changes Apr 7, 2026
View reviewed changes
Comment thread .changeset/silver-sites-tell.md
@mariohamann mariohamann dismissed their stale review April 8, 2026 14:33

Evryhting clarified.

@rahulsuvarna18 rahulsuvarna18 merged commit 8862167 into main Apr 8, 2026
21 checks passed
@rahulsuvarna18 rahulsuvarna18 deleted the fix/combobox-focus branch April 8, 2026 14:36
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariohamann mariohamann mariohamann approved these changes

@MartaPintoTeixeira MartaPintoTeixeira MartaPintoTeixeira left review comments

Assignees

@mariohamann mariohamann

@smfonseca smfonseca

@martascorreia martascorreia

@rahulsuvarna18 rahulsuvarna18

@balco0110 balco0110

@auroraVasconcelos auroraVasconcelos

Labels

None yet

Projects

Solid Design System Project Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rahulsuvarna18 @tega-ekakitie @mariohamann @MartaPintoTeixeira @coraliefeil @smfonseca @martascorreia @balco0110 @auroraVasconcelos