Skip to content

fix: form templates buttons text #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smfonseca merged 2 commits into from
Apr 22, 2026
Merged

fix: form templates buttons text #2938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a49dc
fix: update form button text
smfonseca Apr 20, 2026
0c8c18d
chore: add changeset
smfonseca Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-dodos-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solid-design-system/docs': patch
---

Updated wording of primary buttons in form templates.
4 changes: 2 additions & 2 deletions packages/docs/src/stories/templates/forms.a11y.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test('Contact Form', async ({ page }) => {
- checkbox "I would like to receive marketing emails."
- text: I would like to receive marketing emails.
- text: "* Required fields"
- button "Submit registration"
- button "Send"
- button "Cancel"
`);
});
Expand All @@ -74,7 +74,7 @@ test('Form With Visually Disabled Elements', async ({ page }) => {
- checkbox "I would like to receive marketing emails." [disabled]
- text: I would like to receive marketing emails.
- text: "* Required fields"
- button "Submit registration" [disabled]
- button "Send" [disabled]
- button "Cancel"
`);
});
4 changes: 2 additions & 2 deletions packages/docs/src/stories/templates/forms.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const ContactForm = {
<span class="sd-meta sd-meta--size-sm">* Required fields</span>
</div>
<div class="flex flex-col gap-4 md:flex-row md:justify-end">
<sd-button class="md:order-2" type="submit">Submit registration</sd-button>
<sd-button class="md:order-2" type="submit">Send</sd-button>
<sd-button variant="secondary" class="md:order-1" onclick="alert('Cancelled process')">Cancel</sd-button>
</div>
</form>
Expand Down Expand Up @@ -185,7 +185,7 @@ export const FormWithVisuallyDisabledElements = {
size="sm"
class="button-tooltip"
>
<sd-button class="md:order-2 submit-button" type="submit" visually-disabled>Submit registration</sd-button>
<sd-button class="md:order-2 submit-button" type="submit" visually-disabled>Send</sd-button>
</sd-tooltip>
<sd-button variant="secondary" class="md:order-1" onclick="alert('Cancelled process')">Cancel</sd-button>
</div>
Expand Down
Loading