Skip to content

feat: added realistic template for select#2941

Merged
balco0110 merged 6 commits intomainfrom
feat/add-realistic-select-template
Apr 27, 2026
Merged

feat: added realistic template for select#2941
balco0110 merged 6 commits intomainfrom
feat/add-realistic-select-template

Conversation

@balco0110
Copy link
Copy Markdown
Contributor

@balco0110 balco0110 commented Apr 21, 2026

Description:

Closes: #2150

Definition of Reviewable:

  • Documentation is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Latest commit: da9dac7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-design-system/docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@balco0110 balco0110 moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

🚀 Storybook has been deployed for branch feat_add-realistic-select-template

Copy link
Copy Markdown
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requests:

  • on sample "Choose Fund Category" the copy in figma says "Fund selection (2)" please update code.
  • on sample "City/Region" space between divider and the word "Austria" in figma is 16px. can we change it?
  • on sample "Country" space between divider and the word "Australia" in figma is 16px. can we change it?

Thanks

@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Apr 22, 2026
@balco0110 balco0110 merged commit 6269985 into main Apr 27, 2026
19 checks passed
@balco0110 balco0110 deleted the feat/add-realistic-select-template branch April 27, 2026 09:08
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ Realistic select template

7 participants