Skip to content

fix: add 'icon' to components for versioning in make-versioning script#2945

Merged
mariohamann merged 7 commits intomainfrom
fix/2782-unversioned-icons-inside-css
Apr 30, 2026
Merged

fix: add 'icon' to components for versioning in make-versioning script#2945
mariohamann merged 7 commits intomainfrom
fix/2782-unversioned-icons-inside-css

Conversation

@mariohamann
Copy link
Copy Markdown
Contributor

@mariohamann mariohamann commented Apr 23, 2026

Description:

Tests included. In addition contribution guidelines were updated for Changesets.

Definition of Reviewable:

  • E2E tests (features, a11y, bug fixes) are created/updated

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Latest commit: 59fe067

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@solid-design-system/styles Patch
@solid-design-system/components Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🚀 Storybook has been deployed for branch fix_2782-unversioned-icons-inside-css

smfonseca
smfonseca previously approved these changes Apr 23, 2026
Comment thread CONTRIBUTING.md
@smfonseca smfonseca removed their assignment Apr 23, 2026
@mariohamann mariohamann enabled auto-merge (squash) April 29, 2026 08:25
@mariohamann mariohamann merged commit d379fed into main Apr 30, 2026
19 checks passed
@mariohamann mariohamann deleted the fix/2782-unversioned-icons-inside-css branch April 30, 2026 08:45
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: 🤔 sd-status-badge targets unversioned icon in versioned dist

6 participants