[no ci] feat(1958): add template to sd-input without label but still accessible#2964
Draft
clemens-vi wants to merge 1 commit intofeat/issue-workflow-mcpfrom
Conversation
…le, implemented by agent
github-project-automation
Bot
moved this to 📋 Backlog
in Solid Design System Project Board
|
Contributor
|
🚀 Storybook has been deployed for branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: implemented by agent "Github Issue implementer"
Description:
This pull request adds new accessibility-focused examples and corresponding automated tests for visually hidden labels in both combobox and search input components. These changes demonstrate how to implement visually hidden labels that remain accessible to screen readers, following WCAG guidelines.
Accessibility examples:
ComboboxWithVisuallyHiddenLabel, incombobox.stories.tsto showcase a search combobox with a visually hidden label, including styling and usage notes compliant with WCAG.InputWithVisuallyHiddenLabel, ininput.stories.tsto demonstrate a search input with a visually hidden label, complete with appropriate styling and accessibility warnings.Automated accessibility tests:
Combobox With Visually Hidden Label, incombobox.a11y.tsto verify the accessibility tree for the new combobox example.Input With Visually Hidden Label, ininput.a11y.tsto check the accessibility tree for the new input example.Definition of Reviewable: