[no ci] fix(2057): undefined tailwind variables in production, #2965
Draft
clemens-vi wants to merge 1 commit intofeat/issue-workflow-mcpfrom
Draft
[no ci] fix(2057): undefined tailwind variables in production, #2965clemens-vi wants to merge 1 commit intofeat/issue-workflow-mcpfrom
clemens-vi wants to merge 1 commit intofeat/issue-workflow-mcpfrom
Conversation
… dev-bufgix.agent
github-project-automation
Bot
moved this to 📋 Backlog
in Solid Design System Project Board
|
Contributor
|
🚀 Storybook has been deployed for branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: implemented by dev-bufgix.agent
Description:
This pull request addresses a production bug (#2057) where Tailwind CSS gradient and shadow variables were undefined, causing rendering issues for shadow overlays in table cells and hidden links. The changes ensure these variables are always defined, even when Tailwind is not loaded, and add a Storybook test to verify the fix.
Bug fixes for shadow and gradient CSS variables:
packages/styles/src/modules/table-cell.css: Defines default values for all--tw-gradient-*CSS variables in.sd-table-cellto prevent them from being undefined in production environments without Tailwind.packages/styles/src/modules/hidden-links.css: Sets default values for all--tw-shadow*CSS variables in.sd-hidden-links--multiplefor the same reason.Testing and documentation:
packages/docs/src/stories/styles/table-cell.test.stories.ts: Adds a newShadowStorybook story that demonstrates and verifies the correct rendering of shadow overlays on table cells, ensuring the bug is fixed and variables are present.packages/docs/src/stories/styles/table-cell.test.stories.ts: Importshtmlfromlit-htmlto support the new Storybook story rendering.Definition of Reviewable: