Use 'public' not 'listed' in comments. Implement Boolean range for . #57

timbl · 2021-09-21T15:16:53Z

Trying to phase out "Listed" and "Unlisted" as words for "Public" and "Private".

Implement a range statement which was already in the comments.

TallTed · 2021-09-24T16:03:45Z

solid-terms.ttl

-    dc:issued "2018-01-24"^^xsd:date ;
-    rdfs:comment "Points to an unlisted type index resource."@en ;
+    rdfs:comment
+    """The object is  to a private (unlisted) type index resource.


Suggested change

"""The object is to a private (unlisted) type index resource.

"""The object is a private (unlisted) type index resource.

TallTed · 2021-09-24T16:03:58Z

solid-terms.ttl

    rdfs:subPropertyOf solid:typeIndex ;
-    rdfs:comment "Points to a listed type index resource."@en ;
+    rdfs:comment """The object is  to a pubic ("listed") type index resource..


Suggested change

rdfs:comment """The object is to a pubic ("listed") type index resource..

rdfs:comment """The object is a pubic ("listed") type index resource.

TallTed · 2021-10-01T19:29:07Z

LICENSE.md

@@ -0,0 +1,6 @@
+Copyright 2019 - present


Suggested change

Copyright 2019 - present

Copyright 2019 - 2022 _ENTITY_

present is not valid in a copyright statement; specific year(s) must be listed

the entity claiming copyright must be identified, historically/typically with a human-focused name, potentially including or changing to a machine-focused URI such as a WebID or DID which may be dereferenced to machine- or human-focused details (a/k/a RDF)

Re entity URI, let's revisit this after resolving solid/specification#412 and if still applicable.

jeff-zucker · 2022-06-13T19:56:39Z

We need a third term "restricted". If I have a seeAlso file only accessible to three people and I list it in my public profile, it isn't really a "public" resource. It is publicly discoverable (listed), but only three people can access it. I've noticed confusion over this in the the forum and chats - people assume that a resource restricted to three people is "private", not "public".

matthieubosquet · 2022-06-14T06:58:13Z

Makefile

@@ -0,0 +1,8 @@
+
+
+alcs:


Suggested change

alcs:

acl:

csarven · 2022-06-14T07:27:14Z

LICENSE.md

@@ -0,0 +1,6 @@
+Copyright 2019 - present


Making the following suggestion since we use it elsewhere for code/spec:

Suggested change

Copyright 2019 - present

Copyright 2019 - 2022 W3C Solid Community Group

But may be worth questioning whether the CG should hold the copyright on the repo or another entity.

We included some non-Solid-centric vocabs in this repo so to have open contributions and simplify the update process.

csarven · 2022-06-14T07:28:12Z

solid-terms.ttl

    rdfs:subPropertyOf solid:typeIndex ;
-    rdfs:comment "Points to a listed type index resource."@en ;
+    rdfs:comment """The object is  to a pubic ("listed") type index resource..
+    The subject is the user's webid.


Suggested change

The subject is the user's webid.

The subject is the user's WebID.

csarven · 2022-06-14T07:35:38Z

solid-terms.ttl


 solid:read
    a rdf:Property ;
    dc:issued "2015-12-18"^^xsd:date ;
    rdfs:comment "Indicates if a message has been read or not. This property should have a boolean datatype."@en ;
    rdfs:isDefinedBy <http://www.w3.org/ns/solid/terms#> ;
    rdfs:domain <http://rdfs.org/sioc/ns#Post> ;
+    rdfs:range xsd:boolean;


Suggested change

rdfs:range xsd:boolean;

That can be introduced in a separate PR about solid:read.

Aside: domain sioc:Post is not particularly interesting. (Nowadays messages/notifications tend to be an as:Activity of some kind.)

TallTed · 2022-06-14T14:47:43Z

solid-terms.ttl

+    The triple in found in the private preferences file.
+    (which itself is pointed to from the public profile by space:preferencesFile)


Suggested change

The triple in found in the private preferences file.

(which itself is pointed to from the public profile by space:preferencesFile)

The triple in found in the private preferences file

(which is pointed to from the public profile by space:preferencesFile).

better --

Suggested change

The triple in found in the private preferences file.

(which itself is pointed to from the public profile by space:preferencesFile)

The triple in found in the private preferences file

(to which the public profile points, using space:preferencesFile).

melvincarvalho · 2025-03-14T09:39:29Z

Much prefer:

PublicDocument to ListedDocument
PrivateDocument to UnlistedDocument

It's intuitive and matches other things we have. Will implement this if it's still the plan?

TallTed · 2025-03-14T15:06:21Z

solid-terms.ttl

+    The triple in found in the private preferences file.
+    (which itself is pointed to from the public profile by space:preferencesFile)


Suggested change

The triple in found in the private preferences file.

(which itself is pointed to from the public profile by space:preferencesFile)

The triple in found in the private preferences file

(to which the public profile points, using space:preferencesFile).

melvincarvalho · 2025-05-26T14:48:35Z

We discussed this PR during the last Solid CG call. I have left a meta comment here.

Let's try and get PublicDocument and PrivateDocument over the line, as I think it's going to be an important shape for app discovery.

elf-pavlik · 2025-05-26T15:19:41Z

https://github.com/solid/type-indexes draft report doesn't seem active, still I think it would be important to check with editors if they still plan to work on it or someone else needs to step up.

melvincarvalho · 2025-05-26T15:42:16Z

@elf-pavlik +1

I could potentially work on this as I have been working on a type index app.

But I would prefer to coordinate with the chairs and ODI, and see if @timea-solid still wants to be an active editor.

TallTed · 2025-05-30T18:53:30Z

solid-terms.ttl

-    rdfs:comment "Points to an unlisted type index resource."@en ;
+    rdfs:comment
+    """The object is  to a private (unlisted) type index resource.
+    The subject is the user's webid.


Suggested change

The subject is the user's webid.

The subject is the user's WebID.

TallTed · 2025-05-30T19:18:29Z

@melvincarvalho —

PR #57 was originally submitted on September 21, 2021, and has had suggested changes since September 24, 2021, which suggestions have not been responded to (whether by acceptance, discussion, or otherwise) by the PR originator, @timbl.

Additionally, in the almost four years since changes were first requested on this PR, there have, unsurprisingly, been many commits to the main branch against which this PR is targeted, resulting in conflicts between this PR and that target branch. These conflicts must be resolved, typically by the originator of the PR, before the PR can be merged. (I do not have permissions enabling me to resolve the conflicts, so GitHub does not even provide me with the URL leading to the conflict resolution UI, so I cannot provide it to you.)

Until suggested/requested changes have been acted on (again, whether accepted, discussed, or otherwise), no PR should progress, regardless of whether some specific reviewers have approved it. Such specific reviewers never achieve perfection when reviewing PRs, and typos and other errors may slip past them, no matter how hard they strive for such perfection. Benefiting from such change requests from other people is one of the reasons to embrace Open Source ideals.

All of which is to say, the logjam on this PR starts with its originator, i.e., with @timbl.

Mitzi László and others added 4 commits October 3, 2019 13:11

Create LICENSE.md

222c17a

Use 'public' not 'listed' in comments. Implement bollean range for .

2c37bef

Merge remote-tracking branch 'origin/master' into publicNotListed

bd0f4b8

Merge branch 'main' into publicNotListed

185b2bc

TallTed reviewed Sep 24, 2021

View reviewed changes

Makefile for publishing

c4ce971

TallTed reviewed Oct 1, 2021

View reviewed changes

matthieubosquet reviewed Jun 14, 2022

View reviewed changes

Makefile

@@ -0,0 +1,8 @@

alcs:

Copy link

Member

matthieubosquet Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

alcs:

acl:

csarven requested changes Jun 14, 2022

View reviewed changes

TallTed reviewed Jun 14, 2022

View reviewed changes

csarven added the vocab-solid-terms label Nov 7, 2022

csarven force-pushed the main branch from f5014fe to e965c71 Compare May 26, 2024 18:40

TallTed reviewed Mar 14, 2025

View reviewed changes

melvincarvalho mentioned this pull request May 15, 2025

Slowness in approving PRs #96

Open

TallTed reviewed May 30, 2025

View reviewed changes

	"""The object is to a private (unlisted) type index resource.
	"""The object is a private (unlisted) type index resource.

	rdfs:comment """The object is to a pubic ("listed") type index resource..
	rdfs:comment """The object is a pubic ("listed") type index resource.

	Copyright 2019 - present
	Copyright 2019 - 2022 W3C Solid Community Group

	The subject is the user's webid.
	The subject is the user's WebID.

		The triple in found in the private preferences file.
		(which itself is pointed to from the public profile by space:preferencesFile)

Use 'public' not 'listed' in comments. Implement Boolean range for . #57

Are you sure you want to change the base?

Use 'public' not 'listed' in comments. Implement Boolean range for . #57

Uh oh!

Conversation

timbl commented Sep 21, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TallTed Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TallTed Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeff-zucker commented Jun 13, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvincarvalho commented Mar 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvincarvalho commented May 26, 2025

Uh oh!

elf-pavlik commented May 26, 2025

Uh oh!

melvincarvalho commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TallTed commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TallTed Sep 24, 2021 •

edited

Loading

TallTed Oct 1, 2021 •

edited

Loading

TallTed commented May 30, 2025 •

edited

Loading