Fix(): certificate path should not be relative to current directory#10
Open
GuillaumeOREVE wants to merge 1 commit intosolidstudiosh:mainfrom
Open
Fix(): certificate path should not be relative to current directory#10GuillaumeOREVE wants to merge 1 commit intosolidstudiosh:mainfrom
GuillaumeOREVE wants to merge 1 commit intosolidstudiosh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever I launch the simulator from a folder that is not strictly the root of the simulator project, I get an issue at the end of a charging session, when I try to stop it (and only then):
This proposition of changes fixes the issue.
The alternative would be to instruct clearly on the README to only launch the simulator from its root folder (but I find it not convenient because I use it in a bash script for easing the process of launching it).