Merged
Conversation
dsokal
force-pushed
the
auto-restart
branch
4 times, most recently
from
99a4cb5 to
8d4e11a
Compare
krzysztofciombor-solidstudio
approved these changes
Mar 12, 2026
| logger.info("Auto-restart enabled. Closing old VCP..."); | ||
| vcp.close(); | ||
| logger.info("Waiting for 3 seconds..."); | ||
| await delay(3000); |
Contributor
There was a problem hiding this comment.
Hmm, the delay is already added in the reset message handlers. This will double it, right?
Member
Author
There was a problem hiding this comment.
Yes, this is intentional. I added another delay here to give vcp.close(); on line 13 some time to close everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, the VCP will exit after receiving the
Resetmessage.This PR introduces a new
npm start:auto-restartcommand, that reconnects the VCP after receiving the Reset message.