Update PID controller on every entity change#48
Open
LukasK13 wants to merge 1 commit intosoloam:masterfrom
Open
Update PID controller on every entity change#48LukasK13 wants to merge 1 commit intosoloam:masterfrom
LukasK13 wants to merge 1 commit intosoloam:masterfrom
Conversation
This updates the PID controller whenever any entity state change occurs. To stabilize this, sample_time must be set. This approach only works, when enough entity changes occur in home-assistant but the approach is still better than the current implementation.
soloam
reviewed
Oct 26, 2023
Owner
soloam
left a comment
soloam
left a comment
There was a problem hiding this comment.
Hello, thank you for the push! Let me look at it and test it out! I'll get back to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the PID controller whenever any entity state change occurs. To stabilize this, sample_time must be set. This approach only works, when enough entity changes occur in home-assistant but the approach is still better than the current implementation.
partially fixes #45